build(cudf): Add cudf label to cudf pull request#16976
build(cudf): Add cudf label to cudf pull request#16976jinchengchenghh wants to merge 10 commits intofacebookincubator:mainfrom
Conversation
jinchengchenghh
requested review from
assignUser and
majetideepak
as code owners
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Build Impact AnalysisNo build targets affected by this change. Fast path • Graph from main@682c4a8e72177d8937ad9e12c00bc503cfc15865 |
jinchengchenghh
changed the title
jinchengchenghh
changed the title
jinchengchenghh
changed the title
jinchengchenghh
changed the title
|
Thanks for this. It's been on our mind to do this for a while. But unfortunately I cannot review since I'm not experienced with github workflows. |
| name: Labeler | ||
|
|
||
| on: | ||
| pull_request_target: |
There was a problem hiding this comment.
With pull_request_target, GitHub always runs the workflow from the base branch (e.g., main), not from your PR branch.
|
Thanks for your reply, please make sure the feature worked as you expect, I will ask Meta to verify the semantics. @devavret |
|
The label feature worked as Gluten labels. |
|
Hi, @kgpai , this feature is cudf team want to do, it must take effect after it merged to main since it runs on pull_request_target to access the secret token, could you help merge it? And then we can verify if it worked as we expected. |
|
Hi @majetideepak @czentgr What do you think about that? |
jinchengchenghh
changed the title
jinchengchenghh
changed the title
|
Added @bdice to review the Github workflow. |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # Automatically add labels based on file paths | ||
| cudf: |
There was a problem hiding this comment.
Are there other component labels we should consider adding? (e.g. pyvelox, etc.) It seems like enabling this workflow should be a decision for the Velox core maintainers, I don't want to add this just for cudf unless the core maintainers are aligned that this is desirable.
There was a problem hiding this comment.
This framework now adds cudf labels, let us wait for the Velox core maintainers, they can also add labels like wave, aggregates, iceberg with this framework, there are many labels but they are not used now.
There was a problem hiding this comment.
jinchengchenghh
force-pushed
the
cudf_label
branch
from
5775aa5 to
951f5bf
Compare
4 participants
Add the cudf label by actions/labeler@v5, may also add labels like
iceberg,aggregate,functionsin the future.